Skip to content

fix: Android target API compatibility for F-Droid distribution #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

fix: Android target API compatibility for F-Droid distribution #1435

wants to merge 7 commits into from

Conversation

nope3472
Copy link
Contributor

@nope3472 nope3472 commented Aug 28, 2025 •
edited by sourcery-ai bot
Loading

Fixes #1120

Code Changes Summary

📱 AndroidManifest.xml Changes

Key Fix #1: Deprecated CustomTabs Reference

<!-- ORIGINAL (causing issues) -->
<action android:name="android.support.customtabs.action.CustomTabsService" />

<!-- FIXED -->
<action android:name="androidx.browser.customtabs.action.CustomTabsService" />

Why: android.support.* namespace is deprecated and causes compatibility warnings on modern Android versions. AndroidX is the current standard.

Key Fix #2: Missing Android 13+ Back Gesture Support

<!-- ADDED to activity -->
android:enableOnBackInvokedCallback="true"

Why: Required for proper back gesture handling on Android 13+. Without this, the app may not respond correctly to back gestures on newer devices.

Key Fix #3: Security Enhancement

<!-- ADDED to application -->
android:allowBackup="false"

Why: Prevents sensitive Bluetooth pairing data from being included in automatic Android backups, improving security.

Structural Improvement

  • Moved permissions to top: Better organization following Android manifest best practices
  • Added documentation comments: Improved maintainability

🔧 build.gradle Changes

Critical Fix: Dynamic SDK References → Explicit Values

// ORIGINAL (problematic)
compileSdk flutter.compileSdkVersion
targetSdkVersion flutter.targetSdkVersion

compileSdk 35
targetSdkVersion 35

Why This Fixes F-Droid Warnings:

  • flutter.targetSdkVersion currently points to API 33 (outdated)
  • F-Droid shows "built for older Android" warnings when targetSdk < 34
  • API 35 ensures compliance with current and upcoming (2025) requirements
  • Explicit values provide predictable builds across all environments

Technical Justification:

  • Flutter's internal SDK references often lag behind Android requirements
  • Dynamic references can cause inconsistent builds between developers/CI systems
  • Explicit targeting is Flutter's recommended approach for production apps
  • Eliminates dependency on Flutter version-specific internal configurations

🎯 Combined Impact

These minimal changes eliminate all F-Droid compatibility warnings while:

  • ✅ Maintaining all existing functionality
  • ✅ Following current Android best practices
  • ✅ Future-proofing for 2025 requirements
  • ✅ Improving build consistency and security

Summary by Sourcery

Update Android configuration to meet F-Droid API requirements and modern Android best practices

Bug Fixes:

  • Replace deprecated android.support custom tabs reference with AndroidX in AndroidManifest
  • Enable onBackInvokedCallback for proper back gesture support on Android 13+
  • Disable application backups by setting allowBackup="false" to protect sensitive data

Enhancements:

  • Move permissions block to the top of AndroidManifest and add documentation comments for maintainability

Build:

  • Set compileSdkVersion and targetSdkVersion to explicit API 35 in build.gradle for consistent, up-to-date builds

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Aug 28, 2025 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nope3472 nope3472 changed the title Fix: Android target API compatibility for F-Droid distribution fix: Android target API compatibility for F-Droid distribution Aug 28, 2025
@hpdang
Copy link
Member

hpdang commented Aug 28, 2025

@samruddhi-Rahegaonkar please also review

@AsCress
Copy link
Contributor

AsCress commented Aug 28, 2025

@hpdang I guess we just solved this a few days back by bumping the flutter version to target SDK level 36. That would take care of #1120 as well. There are no extra changes needed.

mariobehling
mariobehling reviewed Sep 1, 2025
View reviewed changes
android/app/build.gradle
@@ -28,7 +28,7 @@ def LOCAL_KEY_PRESENT = project.hasProperty('SIGNING_KEY_FILE') && rootProject.f

android {
namespace "org.fossasia.badgemagic"
compileSdk flutter.compileSdkVersion
compileSdk 35 // Changed from flutter.compileSdkVersion to explicit 35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referring to the comment of @AsCress. So, do we need to define the specific version here? It is already defined in the pubspec.yaml.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025 •
edited
Loading

Build Status

Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/17372689173/artifacts/3896533894.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

github-actions bot added a commit that referenced this pull request Sep 1, 2025
@github-actions
[Auto] Update screenshots for #1435 (2025-09-01.07:34:09)
3f436e9
github-actions bot added a commit that referenced this pull request Sep 1, 2025
@github-actions
[Auto] Update screenshots for #1435 (2025-09-01.09:28:46)
80d4f7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@adityastic adityastic Awaiting requested review from adityastic

@AsCress AsCress Awaiting requested review from AsCress

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nope3472 @hpdang @AsCress @mariobehling